Skip to content

Skip benchmark workflow for bot review events #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 3 commits into from
Feb 21, 2026
Merged

Skip benchmark workflow for bot review events #1192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b48b533
Skip benchmark workflow for bot review events
sbryngelson Feb 21, 2026
6916331
Use unique concurrency group for bot review runs
sbryngelson Feb 21, 2026
ad670bb
Fix bot detection: use unique group for all review events
sbryngelson Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
group: ${{ github.workflow }}-${{ github.ref }}${{ github.event_name == 'pull_request_review' && format('-review-{0}', github.run_id) || '' }}
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This concurrency group now makes every pull_request_review run unique, so human review approvals won’t cancel the pull_request benchmark run and you can end up running benchmarks twice for the same PR. If the intent is only to avoid bot cancellations, restrict the run_id suffix to bot reviews.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/bench.yml, line 10:

<comment>This concurrency group now makes every pull_request_review run unique, so human review approvals won’t cancel the pull_request benchmark run and you can end up running benchmarks twice for the same PR. If the intent is only to avoid bot cancellations, restrict the run_id suffix to bot reviews.</comment>

<file context>
@@ -7,15 +7,12 @@ on:
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}${{ github.event_name == 'pull_request_review' && github.event.review.user.type == 'Bot' && format('-bot-{0}', github.run_id) || '' }}
+  group: ${{ github.workflow }}-${{ github.ref }}${{ github.event_name == 'pull_request_review' && format('-review-{0}', github.run_id) || '' }}
   cancel-in-progress: true
 
</file context>
Suggested change
group: ${{ github.workflow }}-${{ github.ref }}${{ github.event_name == 'pull_request_review' && format('-review-{0}', github.run_id) || '' }}
group: ${{ github.workflow }}-${{ github.ref }}${{ github.event_name == 'pull_request_review' && github.event.review.user.type == 'Bot' && format('-review-{0}', github.run_id) || '' }}

cancel-in-progress: true

jobs:
Expand Down
Loading