Repository navigation
fix: save auto-capture screenshots and honour the toggle - #116
Merged
Merged
Conversation
The screenshot was only written when the first OCR attempt matched no catalog item, so a relic screen that read correctly left only the log.
The backend never read the setting and created a capture folder for every relic run, whatever the toggle showed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-capture only saved
screenshot.bmpwhen the first OCR attempt found no catalog match, so relic screens that read correctly got a log and no image. Each session now saves the frame from its first successful capture.The On/Off toggle was never sent to the backend, which created a capture folder for every relic run. Nothing is captured while the toggle is off, so users who never switched it on stop getting folders.