fix(storage): await IndexedDB transaction completion - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexedDB request success can be followed by transaction rollback, causing callers to acknowledge a cache write that never committed. Retain the transaction and return the request result only from its completion event; preserve request and transaction errors, with AbortError only when no error is available.
Limit the existing closed-connection retry to transaction creation, so an issued operation is never replayed. Add real fake-indexeddb coverage for success followed by abort, completion ordering, readonly/missing values, request and subsequent-transaction errors, and synchronous operation errors.
Validation (Node 24.16.0 / Yarn 4.17.0):
Implements Plan 002; depends on merged #27. Per the requested lifecycle, merge after green CI and clear actual review state; no Codex reviewer is configured.