Merged
Conversation
alexomics
requested changes
Feb 1, 2024
Contributor
alexomics
left a comment
There was a problem hiding this comment.
Overall good, needs to be certain about strand types at specific places!
alexomics
reviewed
Feb 5, 2024
Contributor
alexomics
left a comment
There was a problem hiding this comment.
I think that the logic is clearer, I've made a couple of comments but I think that this is there!
Has it been run against a live/simulated device?
Contributor
|
It has been tested live.... waiting to interpret those tests. |
mattloose
reviewed
Feb 5, 2024
Contributor
Author
bumps coverage >72
WHO wrote this literally crying
…rride, And we were going to unblock this one
So it can be inverted with bitwise NOT to the opposite strand
Fix comparisons of chemistry enum Delete unused code
use new bitwise NOT on strand for possible duplex
Fix typod variable
Move storing duplex tracker alignments/decisions into it's own conditional block
9368620 to
0e823bd
Compare
3bfe556 to
159e49e
Compare
159e49e to
25ebfb1
Compare
Adoni5
commented
Feb 13, 2024
Merged
Contributor
Author
|
This works - @alexomics and @mattloose I'd like to merge so we can address #347 and avoid this languishing so long it no longer works |
Contributor
|
Yes - we know that this works now. I'm happy to merge it. |
mattloose
reviewed
Apr 17, 2024
… chemistry settings
Contributor
Author
|
@alexomics blocked by your requested change for being certain about |
alexomics
approved these changes
Apr 23, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Two implementations of simple duplex targeting
Initial implementation of the "chill" accept if the previous read was deliberately sequenced, and this one otherwise wouldn't be, which has been included to account for sequencing duplex with
no_mapas the decision.The slightly more complex previous alignment was sequenced, and this read aligns to the opposite strand on the same contig.
Both of these modes break the chain of
stop_receivingif the previous read was only sequenced if it was potentially duplex, by checking the newduplex_overridedecision, on theduplex_tracker.Other things of note: