Fix changing directory after 60 seconds if no run folder#323
Merged
Conversation
Contributor
|
Do we want to do this or do we want to allow it to run for longer before erroring? I'm not sure on the best course of action. We don't want to wait for ever of course - but a run can easily take two minutes or more to start? |
Contributor
|
Ok. It's not ideal but this solves the icarust issue. I suggest a revisit in the early new year. We've increased it to 120 as this is the typical warm up time for a run observed over the last few months. |
mattloose
approved these changes
Dec 22, 2023
Contributor
mattloose
left a comment
mattloose
left a comment
There was a problem hiding this comment.
This increases the timeout time 120 seconds and provides a fall back to accommodate alternative simulations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excepts the File Not Found Error if the run folder doesn't appear after 60 seconds - and sets the output directory to the current working directory.