Conversation
Changed 0.5 in targets.py `Analysis` `__init__` to 0.1 defined in `_cli_args.py`
Adoni5
previously approved these changes
Nov 6, 2023
Contributor
Adoni5
left a comment
Adoni5
left a comment
There was a problem hiding this comment.
LGTM. I also changed the default value defined in __init__.py on Analysis of 0.5 to the default 0.1 defined in as the DEFAULT_UNBLOCK const in _cli_args.py.
I did this just to cover eventualities where someone might create there own Analysis class outside of any of our use cases, and not use argparse to setup their Analysis.
In which case 0.5 would be used, but it makes more sense to use the one value we have defined in one place.
Adoni5
approved these changes
Nov 6, 2023
Contributor
Adoni5
left a comment
Adoni5
left a comment
There was a problem hiding this comment.
Update README CHANGELOG to include unreleased changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the specification of unblock duration to a float.