Add profile expiration time to settings page#1917
Conversation
ps2
left a comment
There was a problem hiding this comment.
Nice! Profile Expiration and LoopDocs are DIY Loop specific things, so it should probably live in LoopSupport, which is a DIY Plugin. If you can move it there, I'd be happy to accept this PR. Another option would be to put it behind a feature flag.
…TTINGS_VIEW_ENABLED
|
Added a feature flag
|
|
I can squash commits during merge, thanks. Generally the default state is the DIY state, so I think the flag should be such that without any extra compilation conditions, the profile UI is shown. And we can add the flag to disable it in builds where it shouldn't be shown, so you would not need to submit a Workspace PR. |
|
Sounds great. Thanks. Ok, so my action item is to invert the flag to let the default be enabled. Anything else or good to go after that? |
Chris-Almond
left a comment
There was a problem hiding this comment.
Inverted the feature flag so the default is enabled.
Also squashed a tiny rendering bug that shows hours when days remaining > 3 and hours == 0.
Adding the ability for users to see when their profile expires without waiting for the pop-up warning modal message.
This small enhancement gives users more visibility into the remaining life of their Loop app, to help them plan to rebuild and load fresh profiles.
UI Before
After changes
> 3 Days Dark
> 3 Days Light
< 3 Days Dark
< 3 Days Light