Listen for notification when Insulin Delivery Store updates its cache#1150
Closed
aranasaurus wants to merge 3 commits intoLoopKit:devfrom
Closed
Listen for notification when Insulin Delivery Store updates its cache#1150aranasaurus wants to merge 3 commits intoLoopKit:devfrom
aranasaurus wants to merge 3 commits intoLoopKit:devfrom
Conversation
aranasaurus
commented
Oct 14, 2019
ps2
reviewed
Oct 26, 2019
Collaborator
ps2
left a comment
ps2
left a comment
There was a problem hiding this comment.
Looks good. Just a small comment change request, and please update from dev and then tests should pass for this.
Thanks!
Loop/Managers/LoopDataManager.swift
Outdated
| queue: OperationQueue.main | ||
| ) { (note) in | ||
| self.dataAccessQueue.async { | ||
| self.logger.default("Received notification of cached dosing changing") |
Collaborator
There was a problem hiding this comment.
"cached dosing" -> "insulin delivery store cache"
Collaborator
|
Doing a little cleanup on names: |
ps2
reviewed
Nov 13, 2019
| self.notify(forChange: .bolus) | ||
| } | ||
| }, | ||
| NotificationCenter.default.addObserver( |
Collaborator
There was a problem hiding this comment.
The addObserver above this is not specifying a name for notifications from doseStore. Could you add the right name? I believe it is DoseStore.valuesDidChange.
Author
There was a problem hiding this comment.
Yep I’ll probably be able to do that tomorrow night or this weekend.
Collaborator
|
This can be merged if it is rebased on dev and updated with the new notification name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1037 and requires changes in LoopKit/LoopKit#304