fix: interrupt native compaction turns on cancellation - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
Stop during manual Codex
/compactcurrently cancels the local ACP wait while the native compaction can continue. The emptythread/compact/startresponse was interpreted as an absent turn, although Codex 0.153.4 emits the ordinary turn lifecycle.Summary
Capture the native id from
turn/started, route Stop throughturn/interrupt, and keep the ACP prompt occupied until matching nativeturn/completedor connection closure. Cancellation before the id arrives interrupts the turn on arrival without synthesizing local completion. Compact waiters resolve at the native notification boundary, so interrupt acknowledgements, local interruption fallbacks and item progress cannot release them. Native failure and interruption follow the existing command lifecycle.Visual explanation
Before / after
Test plan
interruptedfollowed by ACPcancelled.Related work
Review focus: after a pre-start cancellation's interrupt ACK, ownership must remain held until a matching native terminal event. Local interrupted completion must never resolve compact waiters. Historical records are not migrated. Lody #618 is unchanged by this follow-up.