Conversation
Model: gpt-5.6-sol Signed-off-by: Dante <duanjl.china@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #652
Problem / pressure
Provider config validation could race with the daemon's replicated config view. A freshly saved config could therefore be reported as missing, while the configuration dialog also allowed probes with an empty required name and surfaced the daemon error instead of the actual input problem.
Summary
provider_config_not_found.Visual explanation
sequenceDiagram participant UI as Config dialog participant CLI as CLI daemon participant Store as Replicated config UI->>Store: persist valid draft UI->>CLI: probe provider CLI->>Store: read provider alt first read misses CLI->>Store: sync + reread once end Store-->>CLI: provider config CLI-->>UI: probe resultBefore / after
Test plan
pnpm --dir packages/components test -- --run tests/agent-config-dialog.test.tsx— 30 tests passed.pnpm --dir apps/cli test -- --run tests/session-execution-service.test.ts— 110 tests passed.pnpm --dir packages/components run typecheck— passed.pnpm --dir apps/cli run typecheck— passed.pnpm exec prettier --check <changed files>— passed.pnpm run docs check— passed with existing repository warnings only.pnpm run lint:fast— 0 errors (473 existing warnings).git diff --check upstream/main...HEAD— passed.Context handoff
Instructions for reviewing agents
session-execution-service.tsand the dialog's persist-before-probe/name-validation flow.Authoring context
Original user prompt
Show original prompt