Repository navigation
chore: replace desktop publishing with changelog releases - #609
Conversation
Model: gpt-6
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e9edfcc0f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| gh release create "$RELEASE_TAG" --verify-tag \ | ||
| --title "Lody OSS $RELEASE_VERSION" --generate-notes |
There was a problem hiding this comment.
Keep changelog releases out of the Latest slot
When a newer stable tag is published after an installer-bearing release, this command creates a normal release that GitHub can automatically mark as Latest; the gh release create --help entry for --latest documents the default as "automatic based on date and version." The packaged macOS client hard-codes /releases/latest/download/appcast.xml in apps/electron/src/main/services/app-updater-sparkle-policy.ts:3-4, but this release uploads no appcast, so installed Macs receive a 404 and can no longer reach even the last preserved binary update. Publish changelog-only releases with --latest=false, or move the updater feed before creating them.
Useful? React with 👍 / 👎.
Problem / pressure
Tag pushes currently build and publish desktop installers and updater feeds. Source releases should instead synchronize app versions and publish a generated changelog without binary assets.
Summary
Replace the Electron packaging workflow with a stable-tag workflow that opens a draft PR updating every
apps/*/package.jsonversion on the default branch, then creates a GitHub Release with generated notes and no uploaded assets. Existing releases are preserved on reruns. Update the release documentation, draft Spec, and owning Agent Note.Visual explanation
Before / after
The tag stays on its original commit; merging the version PR updates the default branch, not the tagged snapshot. Actions must be allowed to create PRs, bot PRs may need maintainer action to start CI, and superseded version PRs should be closed before merging older versions.
Test plan
git diff --check.pnpm checkandpnpm format; blocked by absent workspace dependencies (tsgo/prettier) and uninitialized submodules in this nested checkout.pnpm run docs checkreports pre-existing links into missing submodules; no new documentation errors.Context handoff
Review the separation between immutable tags and default-branch version PRs, permissions needed for bot-created PRs, and preservation of existing releases on reruns. This change intentionally stops publishing new installer/update assets and does not delete historical releases.