Repository navigation
fix: update Codex adapter for ACP v1 goal lifecycle - #465
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
Codex Goals may automatically continue across native turns. Returning the ACP v1 prompt response after the first turn caused Lody to show completed/unread while the goal was still running.
Summary
Update packages/acp-extension-codex to f9dbc8c, which keeps one ACP v1 prompt open across native goal continuations, avoids duplicate turn starts, and pauses the goal on cancellation. Core contracts and Lody ACP v1 support remain unchanged.
Adapter source: LodyAI/acp-extension-codex@f9dbc8c
Before / after
The adapter previously returned after the initial native turn. It now waits until the goal stops and the final turn drains, or execution fails or is cancelled.
Test plan
The submodule now points to the merged adapter commit f9dbc8c. Adapter fix PR: LodyAI/acp-extension-codex#33. Managed runtime publication and rollout remain separate; this PR updates the source pointer only.