Repository navigation
fix(i18n): add missing zh_CN translation keys - #40
Merged
Merged
Conversation
Add 3 keys present in en.json but missing from zh_CN.json: - onboarding.intro.tagline - onboarding.projects.connectedCount_other - sessions.messageQueue.queuedCount_other
lodystage Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Update the gitlink to merged PR #40 (5f0aab0). Its tree is identical to the previously validated ce7b0e8 commit; reuse the registry-backed typechecks and 52 passing tests. Docs check and diff check passed; full checks were not rerun for this pointer-only change. Model: gpt-5
Leeeon233
pushed a commit
that referenced
this pull request
Sep 11, 2026
* fix: control Codex goals through the ACP extension Pausing or resuming a goal was delivered as a chat message (`/goal pause`, `/goal resume`), so it needed the session's ACP prompt slot — the same slot the running goal holds open across the agent's own continuations. The dispatch watcher deferred those turns with `guard-noop-active-session` and the banner disabled every button while it waited, so a paused goal's Resume button did nothing until the user pressed Stop. Goal actions now split by what they do. `pause` and `clear` move durable state only, so they travel out of band on `_lody/session/goal` and land while a prompt is running. `set` and `resume` start work, so they ride a Lody-owned turn carrying `_meta.lody.goalControl`: no command text in the conversation, and the resulting turns still belong to an assistant entry the user can see and cancel. An action that arrives while a turn is draining waits for that turn instead of being dropped, newest action wins, and the banner's pending state now expires. Goal buttons follow the runtime's advertised `goalActions` instead of an `agentType === 'codex'` check, so any agent implementing the extension gets them. Model: claude-opus-5 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: simplify goal controls and record ablation review Remove redundant goal fields, helpers, waiter values, and test details; update the Codex adapter pointer and document the ablation matrix and remaining P1 findings. Validation: targeted tests, full typecheck and lint, formatting, docs, and public boundary checks passed. Full check was stopped after reproducing the known component act failure. Model: gpt-5 * chore: exclude unrelated Electron formatting from goal cleanup Restore the pre-review formatting; no behavior changes. Model: gpt-5 * chore: pin Codex adapter to merged goal prompt PR Update acp-extension-codex from d7969e6 to merged PR #39 commit 33d897b. Validation: 161 targeted tests and docs check passed; pnpm format completed. Codex typecheck fails because the current Core pointer lacks LodyWorktreeProject and worktreeProject capabilities. Full pnpm check timed out. The Core integration remains unresolved; this commit only updates the requested pointer. Model: gpt-5 * chore: align goal adapters with published Core 0.1.4 Pin Core to its 0.1.4 release and Codex to the matching dependency update. Record successful registry-only installation, Codex typechecks, and 52 targeted tests. Validation: workspace typecheck, formatting, and docs checks passed. Full pnpm check timed out at two minutes during lint; full-suite success is not claimed. Model: gpt-5 * chore: pin Codex submodule to merged Core dependency update Update the gitlink to merged PR #40 (5f0aab0). Its tree is identical to the previously validated ce7b0e8 commit; reuse the registry-backed typechecks and 52 passing tests. Docs check and diff check passed; full checks were not rerun for this pointer-only change. Model: gpt-5 * fix: make goal control acceptance non-blocking and preserve queued intent Preserve typed /goal commands while fixing button acknowledgement, cold-session prompt transport, and queued action supersession. Remove the three-turn drop limit and surface startup failures. Validation: 117 CLI and 36 Codex goal tests passed. Workspace typecheck, lint, formatting, and docs checks passed. Full pnpm check timed out during tests after five minutes (exit 124). Model: gpt-5 * chore: simplify goal control guards and regression coverage Remove redundant stale-request validation, duplicate queue lookups, unused acceptance handling, and single-use constant aliases. Consolidate overlapping tests while preserving the observable pre-submission fence regression and document the ablation results. Validation: 115 focused tests passed. Pre-commit workspace typecheck, lint, formatting, and docs checks passed. Full pnpm check encountered component act-is-not-a-function failures and timed out during tests after five minutes (exit 124). Model: gpt-5 * test: complete PR policy fixture for original prompt validation The CI merge includes main’s required Original user prompt section, but the shared validBody fixture omitted it. Add synthetic prompt content without weakening validation or changing policy behavior. Verified the exact CI merge: 102 passed / 2 failed before, 104 passed after. PR-head policy suite: 101 passed. Format check, docs, workspace typecheck, lint and boundary checks passed. Full pnpm check hit component act errors and the five-minute test limit (exit 124). Model: gpt-5 --------- Co-authored-by: Lody Dev <62133302+wibus-wee@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Claude Code <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 3 i18n keys that exist in
locales/en.jsonbut are missing fromlocales/zh_CN.json.Added keys
onboarding.intro.taglineAgents running where the work lives.Agent 在代码所在之处运行。onboarding.projects.connectedCount_other{{count}} projects已连接 {{count}} 个项目sessions.messageQueue.queuedCount_other{{count}} queued{{count}} 条待发送Notes
_othervalues match the base form — consistent with existing_otherentries inzh_CN.json(e.g.sessions.fileProvider.fileCount_other).pnpm lint:i18nand key-diff check.