Conversation
Unverified work in progress: targeted tests could not collect before submodule and dependency setup. Do not treat this commit as a finished fix. Model: gpt-6-sol
Import the typed sync error in session command execution and cover preacceptance resend advice. Model: gpt-6-sol
Issue 398 is a separate report, not an existing pull request. Model: gpt-6-sol
Align the single and batch chat prevalidation assertions with the error returned before an Operation is accepted. Model: gpt-6-sol
|
The current-head Static checks job stopped in I tried rerunning the failed jobs, but GitHub returned |
Merge current main while retaining both the sync-unavailable guidance and local daemon IPC error classification. Model: gpt-6-sol
Related issue
Closes #400
Problem / pressure
When workspace connectivity fails, MCP callers can receive a nonretryable internal error or
COMMAND_REJECTEDfor a temporary dependency failure. The generic sync error also tells tools without anoperationIdparameter to reuse one, while create/chat callers need to know whether an Operation was accepted before choosingresume.Summary
fetch failedtransport error and failed machine-document sync as retryableSYNC_UNAVAILABLE.operationId.operationIdand withoutresumeif sync failed before Operation acceptance. Preserve accepted-Operation recovery behavior.The user authorized this contribution round broadly; the assistant selected #400 and completed the case-specific scope from the issue and code. The original instruction is quoted below without converting that scope into a user-authored prompt.
Visual explanation
Before / after
COMMAND_REJECTED.SYNC_UNAVAILABLE.operationIdreuse even when a tool had no such parameter.Test plan
LODY_DATA_DIR=/private/tmp/lody-400-data corepack pnpm --dir apps/cli exec vitest run src/commands/session.test.ts src/mcp/lody-mcp-server.test.ts --maxWorkers=2— 117 passed on headaa83461272fb59de81a4e53af901c34b2fc25e1e.pnpm format, and docs check passed on prior headaa83461272fb59de81a4e53af901c34b2fc25e1e.75d9a8cddf52c317f15bfc2ad280f7bfb8c10280, the two chat sync assertions now match the pre-acceptance resend guidance. The focused chat-sync/server suite passed 41/41; CLI typecheck, formatting check, andgit diff --checkpassed. The prior CI run Tests (cli) failed only those two stale assertions; the current-head CLI and other test jobs passed. Static checks stopped during Electron postinstall with an HTTP 500 download response, before format/typecheck/lint; the target main Static checks passed dependency installation and downstream checks at SHAe89ab564b24b236f906a3f10baef79d7be0da88a. GitHub denied my failed-job rerun request because it requires repository admin rights.mainat933657b5into head88179e677e0aecc383860e120e529a9dafeedd8e, focused CLI/MCP tests passed 125/125, CLI typecheck,pnpm format, docs check, andgit diff --checkpassed. The merge conflict was limited to preserving both MCP error-handling imports. Current-head CI is pending.Context handoff
Original user prompt
The triggering instruction below is quoted verbatim from the user's broader contribution-round request. The #400-specific implementation scope in this PR was filled in by the assistant under that authorization.
Show original prompt
Sharing refusal (verbatim)
Shared conversation
Status: user-declined
Reason: The user explicitly declined sharing the Lody authoring conversation; their exact reply is quoted above. No public conversation link was supplied.