fix(sdk): ignore retryable reads on the supervised owner pipe - #184
Open
yashranaway wants to merge 2 commits into
Open
fix(sdk): ignore retryable reads on the supervised owner pipe#184yashranaway wants to merge 2 commits into
yashranaway wants to merge 2 commits into
Conversation
DispatchSource and poll can wake with EAGAIN. Treating that as owner exit killed a live supervised host. EOF and real errors still stop it.
macOS 3.14 CI spent 530 ms on a 400 ms budget plus process overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
start --supervisedwatches the owner pipe and shuts the host down on EOF. The old condition wascount >= 0 || errno != EINTR, so a DispatchSource or poll wakeup that returnedEAGAIN/EWOULDBLOCKalso stopped a live host.That is the kind of false owner-exit that leaves Chromium with a closed DevTools pipe.
EOF and unexpected data still stop the host.
EINTR,EAGAIN, andEWOULDBLOCKdo not. The CLI wait loop uses the same helper.Verification
Protocol test covers EOF, data, EINTR, EAGAIN, EWOULDBLOCK, and EBADF.
Security
No transport, JS, or credential change. Supervised hosts still stop when the owner pipe actually closes.