Skip to content

fix(web): categorize docs nav and stop calling sessions isolated - #173

Merged
SarthakWade merged 8 commits into
mainfrom
feat/docs-navigation
Sep 12, 2026
Merged

SarthakWade merged 8 commits into
mainfrom
feat/docs-navigation

Conversation

@yashranaway

Copy link
Copy Markdown
Collaborator

Summary

Implements #159.

  • Docs sidebar uses explicit `documentation` / `trust` categories. No more `slice(0, 3)`.
  • Overview no longer says sessions stay isolated. It renders the COMMANDS.md shared-profile contract.
  • Command reference has a labeled search filter over the generated groups.
  • Overview and commands pages get an on-this-page list. Skip-to-content is in the shell.
  • Provenance lint fails if the isolation claim or positional slicing comes back.

Did not add Settings, Credentials, or SDK pages. Those wait on their contracts.

Closes #159

Docs navigation is now an explicit category catalog instead of slicing
the route list. The overview pulls the shared-profile contract from
COMMANDS.md. The command reference is filterable from that same source.

@SarthakWade SarthakWade left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not merge yet because the Web app does not build and the new command directory has correctness and accessibility gaps.

The exact PR head fails provenance lint and next build because the new shared-session extraction still looks for obsolete wording. After that is corrected, the directory still omits the shipped Credential vault section, leaves table-of-contents links pointing at sections removed by filtering, and does not announce positive result-count changes to assistive technology. Please add focused search, keyboard, responsive, and accessibility coverage as required by issue #159.

GitHub currently reports the PR as mergeable with no conflicts. The Web app required check is failing; the other required checks passed. ESLint, TypeScript, and the dependency audit passed, and I found no dependency vulnerability or secret exposure in this change.

Comment thread apps/web/lib/repository-content.mjs Outdated
Comment thread apps/web/app/docs/commands/page.tsx
Comment thread apps/web/app/docs/commands/page.tsx Outdated
Comment thread apps/web/components/command-directory.tsx Outdated
Extract the session contract from the current shared-profile wording,
include the Credential vault section, drive the on-page TOC from the
filter, and announce result counts to assistive technology.
@yashranaway

Copy link
Copy Markdown
Collaborator Author

Addressed the review: session extraction matches the current COMMANDS.md shared-profile bullet, the directory now includes Credential vault, the filter owns the TOC, and the count is a polite live region with a dedicated lint check.

@SarthakWade SarthakWade left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the final branch after integration with current main. The directory now renders all shipped command groups, includes Credential vault, keeps filtered navigation consistent, announces result changes accessibly, and is covered by real JSDOM behavior tests plus a 375px Chromium test. Local lint, production build, browser test, protocol/security, and runtime suites pass; the required CI matrix is green.

@SarthakWade
SarthakWade merged commit ef918a3 into main Sep 12, 2026
35 of 40 checks passed
@SarthakWade
SarthakWade deleted the feat/docs-navigation branch September 12, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website docs: improve navigation, accuracy, and command discovery

2 participants