Extend MSVC version detection range. Due to MSVC Toolset Minor Version Number 14.40 in VS 2022 v17.10.#46
Merged
wada-at-live2d-com merged 2 commits intoLive2D:developfrom Jun 26, 2024
Conversation
…n Number 14.40 in VS 2022 v17.10. Refer to: https://devblogs.microsoft.com/cppblog/msvc-toolset-minor-version-number-14-40-in-vs-2022-v17-10/
Contributor
Author
|
Appendix:
|
Contributor
|
Thank you for your contribution. |
Contributor
This commit was delegated work by wada-at-live2d-com.
Contributor
Author
|
I pushed appendix commit for updating CHANGELOG as you noted. |
Contributor
|
Thank you for your prompt response! |
wada-at-live2d-com
approved these changes
Jun 26, 2024
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I created a PR because I discovered a build error in CMake process caused by version detection of the build system and compiler.
Please refer to the reason of this case: https://devblogs.microsoft.com/cppblog/msvc-toolset-minor-version-number-14-40-in-vs-2022-v17-10/
When I tried to run a build with the latest version of Visual Studio that I own, I encountered a situation where the compiler version determination process in CMake returned an unexpected value and could not be handled.
This change modifies the hard-coded version number ranges and may not be permanent depending on MSVC updates, but should resolve some immediate inconvenience for users.