This repository was archived by the owner on May 12, 2026. It is now read-only.
add uri length check#262
Merged
Merged
Conversation
saviorand
suggested changes
Jul 26, 2025
Collaborator
saviorand
left a comment
saviorand
left a comment
There was a problem hiding this comment.
Hello, thanks for the contribution! Looks great. I only have one comment.
Could you please take a look?
Collaborator
|
I'll look into fixing the pipeline later today and then merge once the tests pass |
Collaborator
|
Thank you, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add URI length check and return status 414.
This PR is for HTTP/1.1 [3-4] https://github.com/Lightbug-HQ/lightbug_http/issues/120
Add URITooLong to common_response
Add new argument (max_request_uri_length) to server
Check length against max_uri_length
Also, max_request_body_size may not have been implemented properly, so fix that as well.
Please let me know if there are any problems.