Skip to content

Remove Obsolete sys_osml Widget Driver - #99

Merged
gbeeley merged 1 commit into
masterfrom
remove-sys-osml
Sep 3, 2026
Merged

Remove Obsolete sys_osml Widget Driver#99
gbeeley merged 1 commit into
masterfrom
remove-sys-osml

Conversation

@Lightning11wins

Copy link
Copy Markdown
Contributor

According to our discussion on Riot, this widget is obsolete and was never fully implemented, so I've removed it to reduce clutter in the codebase.

It will be with us forever in our hearts (and also in the git tree).
@Lightning11wins Lightning11wins self-assigned this May 7, 2026
@Lightning11wins Lightning11wins added ai-review Request AI review for PRs. size: trivial Easy to review, probably ~100 lines or fewer. labels May 7, 2026
@greptile-apps

greptile-apps Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the sys_osml widget, which was never fully implemented, from both the server-side C driver and the client-side JavaScript file, along with its build and initialization hooks.

  • wgtdrv_sys_osml.c and htdrv_sys_osml.js are deleted entirely; both contained only stubs with no functional logic.
  • centrallix/Makefile.in and centrallix/wgtr/wgtr.c are updated to drop the build artifact and the wgtosmlInitialize() call respectively. A grep across the full repo confirms no remaining references to sys_osml or sys-osml.

Confidence Score: 5/5

Safe to merge — the deleted widget was never fully implemented and all references have been removed from every layer of the stack.

All four touched locations (JS file, C driver, Makefile, init call) are consistent stub removals. A full-repo search confirms no dangling references to sys_osml, sys-osml, or wgtosml remain anywhere in the codebase.

No files require special attention.

Important Files Changed

Filename Overview
centrallix-os/sys/js/htdrv_sys_osml.js JS client file for sys_osml widget deleted entirely; no remaining references in the repo.
centrallix/wgtr/wgtdrv_sys_osml.c C server-side widget driver deleted entirely; contained only stub implementations with no logic.
centrallix/Makefile.in Removes wgtdrv_sys_osml.o from the XWGTRDRIVERS build list; no other changes.
centrallix/wgtr/wgtr.c Removes the wgtosmlInitialize() call from wgtrInitialize() and trailing blank lines at EOF.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[wgtrInitialize] -->|calls| B[wgtosmlInitialize removed]
    A -->|calls| C[wgttabInitialize]
    A -->|calls| D[wgttblInitialize]
    B -->|registered| E[wgtrRegisterDriver: System:OSML Driver removed]
    B -->|registered type| F[wgtrAddType: sys-osml removed]
    G[Makefile.in] -->|compiled| H[wgtdrv_sys_osml.o removed]
    I[htdrv_sys_osml.js removed] -->|client-side stub| J[cn_init function]
Loading

Reviews (1): Last reviewed commit: "Remove obsolete sys_osml widget." | Re-trigger Greptile

@Lightning11wins

Copy link
Copy Markdown
Contributor Author

This PR is ready for human review.

@Lightning11wins
Lightning11wins requested review from gbeeley and nboard May 7, 2026 16:24
@Lightning11wins Lightning11wins changed the title Remove obsolete sys_osml widget. Remove Obsolete sys_osml Widget Driver Jun 8, 2026

@gbeeley gbeeley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks

@gbeeley
gbeeley merged commit f8c7c92 into master Sep 3, 2026
2 checks passed
@Lightning11wins
Lightning11wins deleted the remove-sys-osml branch September 3, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request AI review for PRs. size: trivial Easy to review, probably ~100 lines or fewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants