Skip to content

Fix centrallix-lib Test Linking Failure - #167

Merged
gbeeley merged 2 commits into
masterfrom
fix-lib-test-link
Sep 4, 2026
Merged

Fix centrallix-lib Test Linking Failure#167
gbeeley merged 2 commits into
masterfrom
fix-lib-test-link

Conversation

@Lightning11wins

@Lightning11wins Lightning11wins commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Adds -lm to the centrallix-lib test build so code that #includes math.h and uses it won't cause a linker error.

@Lightning11wins Lightning11wins added ai-review Request AI review for PRs. size: trivial Easy to review, probably ~100 lines or fewer. labels Sep 3, 2026
@Lightning11wins Lightning11wins self-assigned this Sep 3, 2026
@Lightning11wins

Copy link
Copy Markdown
Contributor Author

@greptileai please review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR fixes the centrallix-lib test linkage by appending the math library to LIBS, placing -lm after the test sources and static archive on the linker command line.

  • Adds -lm to the shared linker-library variable.
  • Corrects the order-sensitive linkage issue reported previously.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
centrallix-lib/Makefile.in The math library is now supplied through LIBS, which each relevant link command expands after its objects and archives.

Reviews (2): Last reviewed commit: "Move -lm to LIBS so it follows libCentra..." | Re-trigger Greptile

Comment thread centrallix-lib/Makefile.in Outdated
@Lightning11wins

Copy link
Copy Markdown
Contributor Author

This PR is ready for human review.

@Lightning11wins Lightning11wins changed the title Fix centrallix-lib test link failure Fix centrallix-lib Test Linking Failure Sep 3, 2026

@gbeeley gbeeley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks

@gbeeley
gbeeley merged commit 0ffcef5 into master Sep 4, 2026
2 checks passed
@Lightning11wins
Lightning11wins deleted the fix-lib-test-link branch September 4, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request AI review for PRs. size: trivial Easy to review, probably ~100 lines or fewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants