in_dxf: MINSERT column/row count default to 1 when the group is omitted - #1385
Open
tuxiasumari wants to merge 1 commit into
Open
in_dxf: MINSERT column/row count default to 1 when the group is omitted#1385tuxiasumari wants to merge 1 commit into
tuxiasumari wants to merge 1 commit into
Conversation
DXF omits INSERT groups 70/71 when the count is 1 (ezdxf and AutoCAD both do), so a single-column MINSERT imported with num_cols 0 and dwg2dxf wrote the 0 back out explicitly. Set the documented defaults when the object completes, next to the existing 3DFACE default.
tuxiasumari
force-pushed
the
fix-minsert-grid-defaults
branch
from
August 11, 2026 15:18
1f9b9b1 to
36b1399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
A single-column MINSERT (
71=2, no70group) round-trips as70=0: DXF omits INSERT groups 70/71 when the count is 1 — ezdxf and AutoCAD both do — but the importer materialized the missing group as 0, anddwg2dxfthen writes the explicit 0 back out.Fix
Apply the documented defaults when the MINSERT completes, next to the existing 3DFACE default in the same chain. (Setting them earlier, at the
AcDbMInsertBlockupgrade, does not work: the generic field matcher refuses to overwrite an already-set field when the real 70/71 group arrives.)make checkgreen; 1657-file real-DWG corpus unchanged.