Skip to content

馃寧 ci: Fix Locize Sync CDN Mode - #13465

Merged
danny-avila merged 1 commit into
devfrom
danny-avila/fix-locize-sync-cdn
Jun 2, 2026
Merged

danny-avila merged 1 commit into
devfrom
danny-avila/fix-locize-sync-cdn

Conversation

@danny-avila

Copy link
Copy Markdown
Collaborator

Summary

I fixed the Locize translation sync workflow so the Node 24 upgrade no longer changes which Locize CDN endpoint the sync command uses.

  • Pin locize-cli to 12.2.0 so the workflow does not pull a moving global CLI version on each run.
  • Disable npm install scripts for the transient global CLI install and suppress audit/funding noise in CI.
  • Pass --cdn-type pro explicitly so the workflow keeps using the endpoint expected by the existing LibreChat Locize project.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Ran ruby -e 'require "yaml"; YAML.load_file(".github/workflows/locize-i18n-sync.yml"); puts "yaml ok"'.
  • Ran official actionlint v1.7.12 against .github/workflows/locize-i18n-sync.yml.
  • Ran git diff --check.
  • Verified locize-cli@12.2.0 installs with --ignore-scripts and still reports 12.2.0.
  • Verified locize-cli@12.2.0 sync --help exposes --cdn-type <standard|pro>.
  • Ran npm audit --omit=dev --audit-level=high for locize-cli@12.2.0; it reported found 0 vulnerabilities.

Test Configuration:

  • Node.js: v24.16.0
  • npm: local npm via the current workspace shell
  • actionlint: v1.7.12 darwin/arm64

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local workflow lint/sanity checks pass with my changes

Copilot AI review requested due to automatic review settings June 2, 2026 01:40
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Locize CLI version and explicitly selects the pro CDN endpoint to keep the i18n sync workflow stable after the Node 24 upgrade.

Changes:

  • Pin locize-cli to 12.2.0 and install with --ignore-scripts --no-audit --no-fund.
  • Pass --cdn-type pro to locize sync to match the existing project's CDN.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@danny-avila danny-avila changed the title 馃Л ci: Fix Locize Sync CDN Mode 馃寧 ci: Fix Locize Sync CDN Mode Jun 2, 2026
@danny-avila
danny-avila marked this pull request as ready for review June 2, 2026 01:42
@danny-avila
danny-avila changed the base branch from main to dev June 2, 2026 01:42
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 馃殌

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit a7cfbcc into dev Jun 2, 2026
1 check passed
@danny-avila
danny-avila deleted the danny-avila/fix-locize-sync-cdn branch June 2, 2026 01:47
fuuuzzy pushed a commit to fuuuzzy/LibreChat that referenced this pull request Jun 4, 2026
ThomasVuNguyen pushed a commit to ThomasVuNguyen/LibreChat that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants