Use pyproject and remove setup.py#188
Merged
acdha merged 5 commits intoLibraryOfCongress:masterfrom Feb 27, 2026
Merged
Conversation
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
commented
Jun 5, 2025
edsu
force-pushed
the
rm-setuptools
branch
3 times, most recently
from
74d1545 to
9ba473a
Compare
acdha
force-pushed
the
rm-setuptools
branch
2 times, most recently
from
a9fd421 to
a350cd5
Compare
This commit includes changes to remove the use of setup.py and setuptools in favor of using the existing pyrproject.toml and hatch. A source layout was chosen, which required several changes such as: - pushing bagit.py into src/bagit/ - pushing locale into src/bagit/locale The gettext related code in setup.py was relocated to utils/locales.py It's possible the way that the gettext functionality is setup needs to adjustment, as I'm new to using it. Also we now rely on running tests with uv and pytest, which happens in the test github action. We could chose to update the PyPI publishing step to use uv build/publish too?
acdha
approved these changes
Feb 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes changes to remove the use of setup.py and setuptools in favor of using the existing pyproject.toml and hatch.
A source layout was chosen, which required several changes such as:
The gettext related code in setup.py was relocated to utils/locales.py It's very possible the way that the gettext functionality is setup needs some adjustment, as I'm new to using it.
Also we now rely on running tests with uv and pytest, which happens in the test github action. We could chose to update the PyPI publishing step to use uv build/publish too?