Skip to content

Validates context for activity.#7

Merged
ryasmi merged 1 commit into
masterfrom
issue/valid_context
Apr 12, 2016
Merged

Validates context for activity.#7
ryasmi merged 1 commit into
masterfrom
issue/valid_context

Conversation

@ryasmi

@ryasmi ryasmi commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

@ryasmi

ryasmi commented Apr 11, 2016

Copy link
Copy Markdown
Contributor Author

Any idea why this restriction is required @garemoko?

@ryasmi ryasmi added this to the 0.0.6 milestone Apr 11, 2016
@ryasmi ryasmi self-assigned this Apr 11, 2016
@garemoko

Copy link
Copy Markdown

@ryansmith94 there's no technical requirement disallowing statements from containing those properties with other objects and the LRS shouldn't reject them, but i can't think of a use case where those properties make sense where the object is an agent, statement reference or substatement.

Possibly if the object is an agent representing a robot or clone, then revision and even platform might make sense.

@garemoko

Copy link
Copy Markdown

Luke Skywalker reprogrammed R2D2, platform R2, revision D2.

@ryasmi

ryasmi commented Apr 11, 2016

Copy link
Copy Markdown
Contributor Author

@garemoko the spec states:

The revision property MUST only be used if the Statement's Object is an Activity.
The platform property MUST only be used if the Statement's Object is an Activity.

@garemoko

Copy link
Copy Markdown

@ryansmith94 ha. Good catch. No robot agents then.

@ryasmi

ryasmi commented Apr 11, 2016

Copy link
Copy Markdown
Contributor Author

Ok thanks @garemoko, I'll get this merged then.

@ryasmi
ryasmi merged commit a239144 into master Apr 12, 2016
@ryasmi
ryasmi deleted the issue/valid_context branch April 12, 2016 10:09
@ryasmi ryasmi modified the milestones: 0.0.7, 0.0.6 Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants