Close #16, strip out and refactor all the guts of the app!#32
Merged
LearningNerd merged 26 commits intomasterfrom Jul 10, 2017
Merged
Close #16, strip out and refactor all the guts of the app!#32LearningNerd merged 26 commits intomasterfrom
LearningNerd merged 26 commits intomasterfrom
Conversation
- Change `nextTurnChangeTimestamp` to `timeRemaining` - Rename `currentPlayerIndex` to `turnIndex` - Rename `playerList` to `players`
- Rename `newGistLink` to `newGist` - Rename `playerListChange` to `playerJoined` - Rename `handleUserLogin` to `loginUser`
- Use parameters instead of global variables!
- Use only current player ID, no longer relies on having previous player
ID
- Check if elements exist before modifying them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16, also closes #18 and #14.
Summary of changes:
Set editor to default to read-only mode, allow editing only once current player has been initialized
Refactor state, use
gameStateobject on both server and clientsRefactor events, game initialization, and some UI functions too, stripping out and rebuilding all the guts of this app!
Add and rename/refactor these key client functions:
handleGameState,handlePlayerJoined, andhandlePlayerLeftAdd helper functions to both server and clients for easily accessing player data
Use timestamps on both server and client for the turn timer
Send flag with
turnChangeevent to signal clients not to fork/edit Gist if turn change was triggered by the current player disconnectingUpdate
turnIndexwhen players disconnect (if needed), so index always points to the correct current player (very important bug fix!)