Repository navigation
ci: remove the upstream workflows that cannot run in this fork - #23
Merged
Merged
Conversation
Delete release.yml and update_bypass_list.yml. Both run on a daily schedule and fail at startup every day in this fork. Delete documentation.yml, which deploys the upstream documentation. Delete the two bypass-list scripts. Nothing else uses them. In build_and_test.yml, delete the jobs that run only in the upstream repository: the build_and_test matrix, mac_build, mac_test and build_documentation. Keep check_lint and the Linux sanitizer and Fedora jobs. Describe the change in the Fork tooling section of fork.yaml. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
13 tasks done
After the upstream workflows and jobs are gone, no workflow uses the build, build-docs, build-wheel, test-linux, test-wheel and test-windows actions. Delete them and describe them in the Fork tooling section of fork.yaml. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
5 tasks done
4 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR deletes the upstream workflows that cannot run in this fork.
.github/workflows/release.ymlbuilds and publishes the PyPI wheels. It runs on a daily schedule and fails at startup every day in this fork..github/workflows/update_bypass_list.ymlupdates the upstream bypass list for interaction limits. It needs the token of an upstream maintainer. It runs on a daily schedule and fails at startup every day in this fork..github/workflows/documentation.ymlis a manual workflow that deploys the upstream documentation..github/scripts/update-bypass-list.jsand.github/scripts/find-eligible-contributors.jswere used only byupdate_bypass_list.yml. No other file refers to them.In
.github/workflows/build_and_test.yml, this PR deletes the four jobs that run only inml-explore/mlx(if: github.repository == 'ml-explore/mlx'):build_and_test: the Linux and Windows matrix.mac_build: the macOS build matrix.mac_test: it tests themac_buildoutput on upstream self-hosted runners. It cannot stay withoutmac_build.build_documentation: it builds the upstream documentation.The workflow keeps
check_lint, the Linux sanitizer jobs (ASAN, UBSAN) and the Linux Fedora jobs (x86_64, aarch64). These jobs run today and pass.This PR also deletes the six composite actions in
.github/actionsthat no workflow uses after these deletions:build,build-docs,build-wheel,test-linux,test-wheelandtest-windows. No workflow or action refers to them. One comment insetup.py(line 328) still names.github/actions/build-wheel/action.yml. This PR does not changesetup.py. The actionssetup,build-macosandtest-macosstay only because #22 uses them.fork.yamlmovesbuild_and_test.yml,release.ymland five of the deleted actions from the upstream v0.32.2 section to "Fork tooling". It addsdocumentation.ymlandbuild-docs/action.ymlto "Fork tooling". It removes the globs forupdate_bypass_list.ymland.github/scripts/*. The fork added those files afterbase.hash, so they are not in the diff after this PR.Runner probe result
Not applicable.
Test plan
actionlint .github/workflows/*.yml: no findings.git grepfor the deleted scripts and actions: no workflow or action refers to them. One comment insetup.pyremains (see above)./usr/bin/python3 scripts/check_forkdiff.py --upstream-ref refs/remotes/upstream/main: 171 of 171 changed files described.git merge-tree --write-tree ci/fork-tests ci/drop-upstream-workflows: the only conflict is the threefork.yamllines that the Dependencies section names.gh api repos/Layr-Labs/mlx/commits/<sha> --jq .commit.verification.verifiedgivestruefor both commits.CONTRIBUTING checklist
pre-commitran on the head commit. TheCheck Lintjob passed in run https://github.com/Layr-Labs/mlx/actions/runs/36172223464.Dependencies
None. This PR can merge at any time. #22 also changes
fork.yaml. The two PRs conflict in three adjacent lines of the upstream v0.32.2 glob list, because each PR removes different lines there. To resolve the conflict, remove all three lines. The PR that merges second must be updated frommain. If #22 merges first, an update of this PR also runs the macOS Fork Tests job.🤖 Generated with Claude Code