Skip to content

Make label configurable#36

Merged
DarkGhostHunter merged 1 commit intoLaragear:1.xfrom
michelterstege81:patch-1
Dec 17, 2022
Merged

Make label configurable#36
DarkGhostHunter merged 1 commit intoLaragear:1.xfrom
michelterstege81:patch-1

Conversation

@michelterstege81
Copy link
Copy Markdown
Contributor

Description

This feature allows to set a custom label

Code samples

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2022

Codecov Report

Base: 99.75% // Head: 99.75% // No change to project coverage 👍

Coverage data is based on head (3126046) compared to base (3722cea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x      #36   +/-   ##
=========================================
  Coverage     99.75%   99.75%           
  Complexity      138      138           
=========================================
  Files            18       18           
  Lines           405      405           
=========================================
  Hits            404      404           
  Misses            1        1           
Impacted Files Coverage Δ
src/TwoFactorAuthentication.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DarkGhostHunter
Copy link
Copy Markdown
Contributor

I don't think it would be a breaking change because it only gets written at creation time.

@DarkGhostHunter DarkGhostHunter merged commit 1792c33 into Laragear:1.x Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants