Skip to content

Return empty entries on split #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Olof-Lagerkvist merged 2 commits into from
Jan 24, 2024
Merged

Return empty entries on split #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff1b187
Return empty entries on split
Jan 19, 2024
f2615f0
Restore conditional
Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<Company>LTR Data</Company>
<Authors>Olof Lagerkvist</Authors>
<OutputPath>..\$(Configuration)</OutputPath>
<FileVersion>1.0.9</FileVersion>
<FileVersion>1.0.10</FileVersion>
<GeneratePackageOnBuild Condition="'$(Configuration)' == 'Release'">true</GeneratePackageOnBuild>
<PackageOutputPath>$(LocalNuGetPath)</PackageOutputPath>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
Expand Down
30 changes: 12 additions & 18 deletions LTRData.Extensions/Split/SpanSplitExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ public static StringSplitByStringEnumerator SplitReverse(this ReadOnlySpan<char>
/// <returns>Iterator</returns>
public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char> chars, char delimiter, StringSplitOptions options = StringSplitOptions.None)
{
while (!chars.IsEmpty)
{
do {
var i = chars.Span.IndexOf(delimiter);
if (i < 0)
{
Expand Down Expand Up @@ -94,7 +93,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
}

chars = chars.Slice(i + 1);
}
} while (!chars.IsEmpty);
}

/// <summary>
Expand All @@ -107,8 +106,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
/// <returns>Iterator</returns>
public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char> chars, char delimiter1, char delimiter2, StringSplitOptions options = StringSplitOptions.None)
{
while (!chars.IsEmpty)
{
do {
var i = chars.Span.IndexOfAny(delimiter1, delimiter2);
if (i < 0)
{
Expand Down Expand Up @@ -136,7 +134,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
}

chars = chars.Slice(i + 1);
}
} while (!chars.IsEmpty);
}

/// <summary>
Expand All @@ -148,8 +146,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
/// <returns>Iterator</returns>
public static IEnumerable<ReadOnlyMemory<char>> SplitReverse(this ReadOnlyMemory<char> chars, char delimiter, StringSplitOptions options = StringSplitOptions.None)
{
while (!chars.IsEmpty)
{
do {
var i = chars.Span.LastIndexOf(delimiter);

var value = chars.Slice(i + 1);
Expand All @@ -173,7 +170,7 @@ public static IEnumerable<ReadOnlyMemory<char>> SplitReverse(this ReadOnlyMemory
}

chars = chars.Slice(0, i);
}
} while (!chars.IsEmpty);
}

/// <summary>
Expand All @@ -185,8 +182,7 @@ public static IEnumerable<ReadOnlyMemory<char>> SplitReverse(this ReadOnlyMemory
/// <returns>Iterator</returns>
public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char> chars, ReadOnlyMemory<char> delimiter, StringSplitOptions options = StringSplitOptions.None)
{
while (!chars.IsEmpty)
{
do {
var i = chars.Span.IndexOf(delimiter.Span);
if (i < 0)
{
Expand Down Expand Up @@ -214,7 +210,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
}

chars = chars.Slice(i + delimiter.Length);
}
} while (!chars.IsEmpty);
}

/// <summary>
Expand All @@ -226,8 +222,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
/// <returns>Iterator</returns>
public static IEnumerable<ReadOnlyMemory<char>> SplitReverse(this ReadOnlyMemory<char> chars, ReadOnlyMemory<char> delimiter, StringSplitOptions options = StringSplitOptions.None)
{
while (!chars.IsEmpty)
{
do {
var i = chars.Span.LastIndexOf(delimiter.Span);

var value = i >= 0 ? chars.Slice(i + delimiter.Length) : chars;
Expand All @@ -251,7 +246,7 @@ public static IEnumerable<ReadOnlyMemory<char>> SplitReverse(this ReadOnlyMemory
}

chars = chars.Slice(0, i);
}
} while (!chars.IsEmpty);
}

/// <summary>
Expand All @@ -264,8 +259,7 @@ public static IEnumerable<ReadOnlyMemory<char>> SplitReverse(this ReadOnlyMemory
/// <returns>Iterator</returns>
public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char> chars, ReadOnlyMemory<char> delimiter, StringSplitOptions options, StringComparison comparison)
{
while (!chars.IsEmpty)
{
do {
var i = chars.Span.IndexOf(delimiter.Span, comparison);
if (i < 0)
{
Expand Down Expand Up @@ -293,7 +287,7 @@ public static IEnumerable<ReadOnlyMemory<char>> Split(this ReadOnlyMemory<char>
}

chars = chars.Slice(i + delimiter.Length);
}
} while (!chars.IsEmpty);
}
}

Expand Down