Point plus extended - #95
Merged
nkhadka21 merged 54 commits intoNov 27, 2023
Merged
Conversation
…plus_extended source case in len_pop.py
… len.py from source.py
…or a given lens at given observation times.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 77.65% 78.00% +0.35%
==========================================
Files 27 29 +2
Lines 1432 1473 +41
==========================================
+ Hits 1112 1149 +37
- Misses 320 324 +4
|
Collaborator
Author
|
Hi @sibirrer, I resolved all your comments! |
for more information, see https://pre-commit.ci
…nto point_plus_extended merged to main
for more information, see https://pre-commit.ci
sibirrer
approved these changes
Nov 27, 2023
sibirrer
left a comment
sibirrer
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a point + extended source skeleton.