Repository navigation
fix(operator): keep collecting usage past a failed write - #316
Merged
Merged
Conversation
One deployment's write failing left every deployment behind it in the iteration order with no reading at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #315.
collect_usagepropagated the first failed write with?, so one deployment's error left every deployment behind it in the iteration order with no reading at all (lnvps_operator/src/app_deployments.rs:1348). Both writes now log and move on, matching what the compose-parse failures a few lines below already did.collect_usagetakes the db and the metrics client rather than the wholeContext, so the test does not need a kube client.MockDbgainsfailing_usage_writes, the only way to reach a failing write from a test.Verified at
2a1557a:cargo test --workspace --exclude lnvps_e2e854 passed / 0 failed, e2e 163 pass, fmt clean and no new clippy warnings on either crate. The new test fails on the old code withusage write denied for 1.From the lnvps channel.