Repository navigation
fix(engine): skip the TypeScript check until dependencies are installed - #2343
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After each write to a project with a
tsconfig.json, the harness ranbunx tsc --noEmiteven beforebun install. It failed withTS2688: Cannot find type definition file for 'bun-types'and was reported as__BUILD_UNVERIFIED__, so the model kept explaining the same failure (session01a16a48…, 6 times). When a project haspackage.jsonand nonode_modulesin its folder or any folder above, the check is now skipped and says why: dependencies are not installed; install them, then verify.Changelog
The agent no longer runs a failing TypeScript check before a project's dependencies are installed.
Testing
cargo test --workspace(newtypescript_check_waits_for_installed_dependencies).https://claude.ai/code/session_019NPDUr9WpDReZsGXHf8XW7