Repository navigation
fix(engine): offer localhost_preview in the request that describes it - #2341
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In Mac app sessions the system prompt described
localhost_preview(network.rs), but the provider request rebuilt its tool policy inturn/request.rswithout it. The model was told to use a tool missing from its function list, and in session01a16a48…it spent ~4 rounds saying "let me open the preview" and running unrelated commands. Both builders now use one helper,network::root_schema_policy.Changelog
The agent can now actually open the live preview in the Mac app; before, it was told about the tool but never given it.
Testing
cargo check --workspace --tests,cargo test --workspace(newrequest_policy_offers_preview_with_a_client). One unrelated flaky failure,context::tests::environment_cache_observes_external_instructions_and_tree_changes, passes when re-run alone.https://claude.ai/code/session_019NPDUr9WpDReZsGXHf8XW7