Repository navigation
fix(engine): choose the LAN address for QR pairing - #1927
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/remotepreviously started a gateway on localhost, which a phone could scan but could not reach. Default to automatic Wi-Fi/Ethernet selection and embed the selected Mac address in pairing details. Prefer physical LAN interfaces, use the OS route to resolve ties, exclude virtual bridges/link-local addresses, and retain an offline loopback fallback. Explicit bind and advertised-address overrides keep their behavior.Update setup and loopback guidance for same-Wi-Fi scanning. Repair a response-reconstruction regression test that discarded ordinary text deltas carrying the new optional turn timing metadata.
Validation:
cargo check --workspace --tests,cargo test --workspace, andcargo fmt --all -- --checkpassed. New address regressions were observed failing before fixes. An isolated real gateway started with no bind option; its listener and QR agreed on the Mac LAN address, and the QR credential paired successfully over that LAN WebSocket. Independent code review found no remaining blocking issues. Physical iPhone scanning is deferred at the user's request.Closes #1925
Closes #1926