Repository navigation
fix(tui): show remote pairing in a full-height panel - #1919
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/remotewas capped at 18 terminal rows, while its pairing QR alone needs about 29. The Remote command panel now occupies the entire terminal viewport, including the composer/footer space, and uses the same full-screen geometry for mouse selection. Other command panels retain their bounded layout.Pairing details come first: the manual address and code are above the QR, with session status and loopback guidance below. Explicit black-on-white QR colours survive the final panel render. Closing the panel restores the composer and draft. A hidden activity-indicator hold is cleared so opening Remote between turns cannot leave the renderer continually scheduling frames.
Fixes #1918
Validation:
cargo fmt --all -- --checkcargo check --workspace --testsRUST_TEST_THREADS=4 cargo test --workspacescripts/check-frontend-seam.shandgit diff --check/remotestarts the gateway, registers the session, shows the manual address/code and the complete coloured QR, and closes normally. The existing user gateway/config were untouched.The first workspace run timed out in the existing
a_remote_cancel_stops_only_the_turn_it_namestest; it passed in isolation and the final workspace run passed with reduced concurrency. Initial Linux CI receivedowner_exitedinstead ofsharing_disabledin the existing gateway end-to-end test; that intermittent close-reason defect is tracked in #1920. The unchanged test passed on baseline main, and the complete Linux job passed on retry. All CI checks passed. Camera scanning and real iPhone connectivity were not tested.