Skip to content

Porting MultiPart event generator from sbncode to larsoft#153

Merged
lgarren merged 3 commits intoLArSoft:developfrom
LauPM:feature/laurapm_evtgen_multipart
May 12, 2025
Merged

Porting MultiPart event generator from sbncode to larsoft#153
lgarren merged 3 commits intoLArSoft:developfrom
LauPM:feature/laurapm_evtgen_multipart

Conversation

@LauPM
Copy link
Copy Markdown
Contributor

@LauPM LauPM commented Apr 3, 2025

Tested and usable for ICARUS, SBND and DUNE

@FNALbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @LauPM (Laura Pérez-Molina) for develop.

It involves the following packages:

larsim

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Copy Markdown
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Copy Markdown
Contributor

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larsim/EventGenerator/MultiPart/MultiPartRain_module.cc \ 
  larsim/EventGenerator/MultiPart/MultiPartVertex_module.cc

Then commit the changes and push them to your PR branch.

@FNALbuild
Copy link
Copy Markdown
Contributor

Pull request #153 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Copy Markdown
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Copy Markdown
Contributor

+code-checks

@knoepfel knoepfel moved this to Awaiting triage in LArSoft pull requests Apr 14, 2025
@knoepfel knoepfel changed the title Porting MultiPart event generator from sbncode lo larsoft Porting MultiPart event generator from sbncode to larsoft Apr 14, 2025
@knoepfel knoepfel moved this from Awaiting triage to Approval in progress in LArSoft pull requests Apr 14, 2025
@knoepfel
Copy link
Copy Markdown
Member

trigger build

@FNALbuild
Copy link
Copy Markdown
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

-SBND tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/16817&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/25915&builds=

@FNALbuild
Copy link
Copy Markdown
Contributor

Pull request #153 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Copy Markdown
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Copy Markdown
Contributor

+code-checks

@lgarren
Copy link
Copy Markdown
Member

lgarren commented Apr 30, 2025

trigger build

@FNALbuild
Copy link
Copy Markdown
Contributor

The tests are being triggered in jenkins.

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

@FNALbuild
Copy link
Copy Markdown
Contributor

-DUNE tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/19396&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26211&builds=

@lgarren
Copy link
Copy Markdown
Member

lgarren commented May 12, 2025

approve

@FNALbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit 988f81e into LArSoft:develop May 12, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Approval in progress to Merged into develop in LArSoft pull requests May 12, 2025
@lgarren lgarren moved this from Merged into develop to Included in release in LArSoft pull requests May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Included in release

Development

Successfully merging this pull request may close these issues.

4 participants