Skip to content

[CH-410] Fix coredump issue caused by broadcast join #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuneng1994 merged 1 commit into from
Apr 10, 2023
Merged

[CH-410] Fix coredump issue caused by broadcast join #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions utils/local-engine/Common/CHUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,8 @@ void BackendInitializerUtil::init(const std::string & plan)

void BackendFinalizerUtil::finalizeGlobally()
{
local_engine::BroadCastJoinBuilder::clean();

auto & global_context = SerializedPlanParser::global_context;
auto & shared_context = SerializedPlanParser::shared_context;
auto * logger = BackendInitializerUtil::logger;
Expand All @@ -648,11 +650,8 @@ void BackendFinalizerUtil::finalizeGlobally()
}
}

void BackendFinalizerUtil::finalizeSessionall()
void BackendFinalizerUtil::finalizeSessionally()
{
/// TODO: figure out why BroadCastJoinBuilder::clean would cause core issue
/// Currently remove it as a workaround
// local_engine::BroadCastJoinBuilder::clean();
}

}
2 changes: 1 addition & 1 deletion utils/local-engine/Common/CHUtil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class BackendFinalizerUtil
static void finalizeGlobally();

/// Release session level resources like StorageJoinBuilder. Invoked every time executor/driver shutdown.
static void finalizeSessionall();
static void finalizeSessionally();
};

}
2 changes: 1 addition & 1 deletion utils/local-engine/local_engine_jni.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ void Java_io_glutenproject_vectorized_ExpressionEvaluatorJniWrapper_nativeInitNa
void Java_io_glutenproject_vectorized_ExpressionEvaluatorJniWrapper_nativeFinalizeNative(JNIEnv * env)
{
LOCAL_ENGINE_JNI_METHOD_START
local_engine::BackendFinalizerUtil::finalizeSessionall();
local_engine::BackendFinalizerUtil::finalizeSessionally();
LOCAL_ENGINE_JNI_METHOD_END(env, )
}

Expand Down