Skip to content

[CH-402]Enable return null and complex type for get_json_object function - #403

Merged
liuneng1994 merged 2 commits into
Kyligence:clickhouse_backendfrom
KevinyhZou:adapt_get_json_object
Apr 10, 2023
Merged

[CH-402]Enable return null and complex type for get_json_object function#403
liuneng1994 merged 2 commits into
Kyligence:clickhouse_backendfrom
KevinyhZou:adapt_get_json_object

Conversation

@KevinyhZou

@KevinyhZou KevinyhZou commented Apr 6, 2023

Copy link
Copy Markdown

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Enable return null and complex type for get_json_object function. By adapt to 2 settings function_json_value_return_type_allow_nullable and function_json_value_return_type_allow_complex as introduced in pr : ClickHouse#47494. The issue is described in #402

@kyligence-git

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@KevinyhZou KevinyhZou changed the title Enable return null and complex type for get_json_object function [CH-402]Enable return null and complex type for get_json_object function Apr 6, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要在这个位置修改配置。。不可以在最开始的时候配置好吗。在解析计划的时候修改context似乎不太合理

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不应该在这里修改context

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@KevinyhZou
KevinyhZou force-pushed the adapt_get_json_object branch from 8666231 to 03b43bb Compare April 6, 2023 12:42
@KevinyhZou

Copy link
Copy Markdown
Author

Fixed done @liuneng1994

@liuneng1994

Copy link
Copy Markdown

test this please

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
liuneng1994 merged commit 876a30d into Kyligence:clickhouse_backend Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants