Skip to content

Fix UT of benchmark_local_engine.cpp - #400

Merged
liuneng1994 merged 5 commits into
Kyligence:clickhouse_backendfrom
bigo-sg:fixut
Apr 10, 2023
Merged

Fix UT of benchmark_local_engine.cpp#400
liuneng1994 merged 5 commits into
Kyligence:clickhouse_backendfrom
bigo-sg:fixut

Conversation

@zhanglistar

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@kyligence-git

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

1 similar comment
@kyligence-git

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994

Copy link
Copy Markdown

test this please

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
liuneng1994 merged commit 3028f6b into Kyligence:clickhouse_backend Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants