Skip to content

[CH-397] support posexplode/sequence functions - #399

Merged
liuneng1994 merged 24 commits into
Kyligence:clickhouse_backendfrom
bigo-sg:gluten_397
Apr 12, 2023
Merged

[CH-397] support posexplode/sequence functions#399
liuneng1994 merged 24 commits into
Kyligence:clickhouse_backendfrom
bigo-sg:gluten_397

Conversation

@taiyang-li

@taiyang-li taiyang-li commented Apr 4, 2023

Copy link
Copy Markdown

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

I check-pick prs from CH because posexplode/sequence/mapFromArrays functions need them:

This pr also fix #410

@kyligence-git

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@taiyang-li

Copy link
Copy Markdown
Author

test this please with 1281

@taiyang-li
taiyang-li marked this pull request as draft April 4, 2023 09:48
@taiyang-li taiyang-li changed the title [CH-397] support spark sequence function [CH-397] support posexplode/sequence/mapFromArrays functions Apr 7, 2023
@taiyang-li taiyang-li changed the title [CH-397] support posexplode/sequence/mapFromArrays functions [CH-397] support posexplode/sequence functions Apr 7, 2023
@taiyang-li
taiyang-li marked this pull request as ready for review April 7, 2023 09:54
@taiyang-li

Copy link
Copy Markdown
Author

test this please with 1281

@taiyang-li

Copy link
Copy Markdown
Author

performance tests

select count(1) from (select l_orderkey, posexplode(array('1', '2')), l_suppkey from lineitem)  ;

set spark.gluten.sql.columnar.generate=true;
1 row selected (0.227 seconds) 

set spark.gluten.sql.columnar.generate=false;
1 row selected (1.106 seconds)

@taiyang-li

Copy link
Copy Markdown
Author

test this please with 1281

2 similar comments
@taiyang-li

Copy link
Copy Markdown
Author

test this please with 1281

@taiyang-li

Copy link
Copy Markdown
Author

test this please with 1281

@taiyang-li

Copy link
Copy Markdown
Author

test this please with 1281

@zzcclp
zzcclp requested a review from liuneng1994 April 12, 2023 01:04

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
liuneng1994 merged commit 0417ceb into Kyligence:clickhouse_backend Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coredump when ut exit, seems related to resource release of BroadCastJoinBuilder

4 participants