Skip to content

[CH-383] Fix 'Unknown identifier' exception - #385

Merged
liuneng1994 merged 1 commit into
Kyligence:clickhouse_backendfrom
exmy:CH-383
Mar 31, 2023
Merged

[CH-383] Fix 'Unknown identifier' exception#385
liuneng1994 merged 1 commit into
Kyligence:clickhouse_backendfrom
exmy:CH-383

Conversation

@exmy

@exmy exmy commented Mar 28, 2023

Copy link
Copy Markdown

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

#383

@kyligence-git

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@liuneng1994

Copy link
Copy Markdown

test this please

ActionsDAG::NodeRawConstPtrs args = {require_node};
const auto & node = actionsDag->addFunction(function_builder, args, item);
actionsDag->addOrReplaceInOutputs(node);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么会出现require的列不存在于actionDag的output中呢

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种 case:where event.log_extra['abflags_v2'] is not null and hdid is not null and hdid != '',
output 是 and(and(and(isNotNull(event),isNotNull(arrayElement(tupleElement(event,1_0),abflags_v2_1))),isNotNull(hdid)),not(equals(hdid,_2))) ,
arrayElement(tupleElement(event,1_0),abflags_v2_1)) 是中间结果,不在 output 中

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
liuneng1994 merged commit f57ffab into Kyligence:clickhouse_backend Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants