Skip to content

[CH-364] Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit - #377

Merged
liuneng1994 merged 14 commits into
Kyligence:clickhouse_backendfrom
bigo-sg:fix_buildes_typo
Mar 29, 2023
Merged

[CH-364] Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit#377
liuneng1994 merged 14 commits into
Kyligence:clickhouse_backendfrom
bigo-sg:fix_buildes_typo

Conversation

@taiyang-li

@taiyang-li taiyang-li commented Mar 24, 2023 •
edited
Loading

Copy link
Copy Markdown

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit(current not).
  • Make sure every correspoinding settings and configs are applied at JNI_Onload (current not).
  • Some refactor works.

@kyligence-git

kyligence-git commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@taiyang-li taiyang-li changed the title Make sure global_context is initialized once at the first invoking and finalized once at exit [CH-364] Make sure global_context is initialized once at the first invoking and finalized once at exit Mar 24, 2023
@taiyang-li

taiyang-li commented Mar 24, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li taiyang-li changed the title [CH-364] Make sure global_context is initialized once at the first invoking and finalized once at exit [CH-364] Make sure global_context is initialized once at the first invoking of JNI_Onload and finalized once at exit Mar 24, 2023
@liuneng1994

liuneng1994 commented Mar 24, 2023

Copy link
Copy Markdown

test this please with 1143

@taiyang-li

taiyang-li commented Mar 24, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li

taiyang-li commented Mar 25, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li

taiyang-li commented Mar 25, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li

taiyang-li commented Mar 25, 2023

Copy link
Copy Markdown
Author

test this please with 1143

2 similar comments
@taiyang-li

taiyang-li commented Mar 25, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@liuneng1994

liuneng1994 commented Mar 27, 2023

Copy link
Copy Markdown

test this please with 1143

@taiyang-li

taiyang-li commented Mar 27, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li

taiyang-li commented Mar 28, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li

taiyang-li commented Mar 28, 2023

Copy link
Copy Markdown
Author

test this please with 1143

1 similar comment
@taiyang-li

taiyang-li commented Mar 29, 2023

Copy link
Copy Markdown
Author

test this please with 1143

@taiyang-li

taiyang-li commented Mar 29, 2023

Copy link
Copy Markdown
Author

test this please with 1143

liuneng1994
liuneng1994 approved these changes Mar 29, 2023
View reviewed changes

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994
liuneng1994 merged commit ea4a475 into Kyligence:clickhouse_backend Mar 29, 2023
@taiyang-li
taiyang-li deleted the fix_buildes_typo branch April 13, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@liuneng1994 liuneng1994 liuneng1994 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taiyang-li @kyligence-git @liuneng1994