Skip to content

Support full join with join condition - #366

Merged
zzcclp merged 1 commit into
Kyligence:clickhouse_backendfrom
loneylee:fulljoin
Mar 23, 2023
Merged

Support full join with join condition#366
zzcclp merged 1 commit into
Kyligence:clickhouse_backendfrom
loneylee:fulljoin

Conversation

@loneylee

@loneylee loneylee commented Mar 16, 2023

Copy link
Copy Markdown

Changelog category (leave one):

  • New Feature
    Support full join with join condition.

test by spark ut

@kyligence-git

kyligence-git commented Mar 16, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@loneylee

loneylee commented Mar 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

#334

@loneylee loneylee mentioned this pull request Mar 20, 2023
Merged
@loneylee

loneylee commented Mar 20, 2023

Copy link
Copy Markdown
Author

test this please with 1164

1 similar comment
@loneylee

loneylee commented Mar 20, 2023

Copy link
Copy Markdown
Author

test this please with 1164

@loneylee

loneylee commented Mar 20, 2023

Copy link
Copy Markdown
Author

apache/gluten#1164

@loneylee

loneylee commented Mar 20, 2023

Copy link
Copy Markdown
Author

test this please with 1164

1 similar comment
@loneylee

loneylee commented Mar 20, 2023

Copy link
Copy Markdown
Author

test this please with 1164

liuneng1994
liuneng1994 reviewed Mar 20, 2023
View reviewed changes
Comment thread utils/local-engine/Parser/SerializedPlanParser.h Outdated

@liuneng1994 liuneng1994 Mar 20, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一块的逻辑考虑下能不能单独抽一个类出来

@loneylee loneylee Mar 22, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

liuneng1994
liuneng1994 reviewed Mar 20, 2023
View reviewed changes
Comment thread utils/local-engine/Parser/SerializedPlanParser.cpp Outdated

@liuneng1994 liuneng1994 Mar 20, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是可以搞一个util函数专门做json的序列化

@loneylee loneylee Mar 22, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with debugstring

liuneng1994
liuneng1994 reviewed Mar 20, 2023
View reviewed changes
Comment thread utils/local-engine/Parser/SerializedPlanParser.cpp Outdated
@loneylee

loneylee commented Mar 22, 2023

Copy link
Copy Markdown
Author

test this please with 1164

liuneng1994
liuneng1994 approved these changes Mar 23, 2023
View reviewed changes

@liuneng1994 liuneng1994 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp
zzcclp merged commit 0c8ea4e into Kyligence:clickhouse_backend Mar 23, 2023
@loneylee
loneylee deleted the fulljoin branch March 23, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@liuneng1994 liuneng1994 liuneng1994 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@loneylee @kyligence-git @liuneng1994 @zzcclp