fix: check for request validator plugin in openAPI2kong cmd for path param schema#281
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 69.62% 69.73% +0.10%
==========================================
Files 24 24
Lines 2736 2739 +3
==========================================
+ Hits 1905 1910 +5
+ Misses 656 653 -3
- Partials 175 176 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shivaygupta-dotcom LGTM, couple of things -
|
9548b32 to
a5bcc33
Compare
| @@ -0,0 +1,34 @@ | |||
| openapi: 3.0.0 | |||
There was a problem hiding this comment.
Is this needed since there are no path/operation parameters?
| @@ -0,0 +1,50 @@ | |||
| openapi: 3.0.0 | |||
There was a problem hiding this comment.
Since this file already covers both parameter at both path and operation levels, do we need additional individual tests for same?
There was a problem hiding this comment.
We have discussed this offline. Please check and verify on this once.
| required: true | ||
| schema: | ||
| type: string | ||
| enum: |
There was a problem hiding this comment.
@shivaygupta-dotcom this is missing indentation
There was a problem hiding this comment.
And leading to enum being missed in the expected file plugin schema
There was a problem hiding this comment.
pushed changes.
https://konghq.atlassian.net/browse/FTI-7191