Migrate Pourbaix workflow to pyEQL v1.5.0#369
Open
SuixiongTay wants to merge 11 commits intoKingsburyLab:mainfrom
Open
Migrate Pourbaix workflow to pyEQL v1.5.0#369SuixiongTay wants to merge 11 commits intoKingsburyLab:mainfrom
pyEQL v1.5.0#369SuixiongTay wants to merge 11 commits intoKingsburyLab:mainfrom
Conversation
Collaborator
Author
|
Hi @rkingsbury , I noticed the Should I target this PR against the |
pyEQL v1.5.0pyEQL v1.5.0
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
===========================================
- Coverage 86.10% 68.82% -17.29%
===========================================
Files 14 18 +4
Lines 1821 3095 +1274
Branches 313 546 +233
===========================================
+ Hits 1568 2130 +562
- Misses 209 883 +674
- Partials 44 82 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the previous
pourbaixtopourbaix_pyEQL_v1.5branch.Content
pourbaix_api.pypourbaix_diagram.pyion.pycompatibility.pyMP2020Compatibility.yamlmpr_reference_ion_database.jsonpourbaix_test_data.jsonpymatgentest_pourbaix_api.pytest_pourbaix_diagram.pyNote
emmet-coreusestyping.NotRequiredwhich was introduced in python3.11.pytest.importskipis used to skip through python3.10to avoid the error.Addressing #368