Skip to content

OpenCode v1.3.9#8812

Merged
catrielmuller merged 27 commits into
mainfrom
catrielmuller/kilo-opencode-v1.3.9
Apr 12, 2026
Merged

OpenCode v1.3.9#8812
catrielmuller merged 27 commits into
mainfrom
catrielmuller/kilo-opencode-v1.3.9

Conversation

@catrielmuller

Copy link
Copy Markdown
Contributor
  • Fixed plugin entrypoint resolution for paths without leading dot

import { Icon } from "@opencode-ai/ui/icon"
import { showToast } from "@opencode-ai/ui/toast"
import type { QuestionAnswer, QuestionRequest } from "@kilocode/sdk/v2"
import type { QuestionAnswer, QuestionRequest } from "@opencode-ai/sdk/v2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing kilo import

Comment thread packages/app/src/pages/session.tsx Outdated
@@ -1,4 +1,4 @@
import type { Project, UserMessage } from "@kilocode/sdk/v2"
import type { Project, UserMessage } from "@opencode-ai/sdk/v2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing kilo import too

@catrielmuller catrielmuller merged commit e985060 into main Apr 12, 2026
13 of 14 checks passed
@catrielmuller catrielmuller deleted the catrielmuller/kilo-opencode-v1.3.9 branch April 12, 2026 18:51
setStore("editing", false)
const picked = (answer: string) => store.answers[store.tab]?.includes(answer) ?? false

const pick = (answer: string, custom: boolean = false) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Single-select answers no longer submit immediately

Before this refactor, choosing a single option called reply([[answer]]), which completed the question flow as soon as the user clicked. pick() now only updates local state, so single-choice prompts require an extra Next/Submit click and any downstream behavior that depended on the immediate reply no longer runs.

})
yield* Effect.promise(() => KiloSession.removeSession(sessionID))
KiloSession.clearPlatformOverride(sessionID)
SessionPrompt.cancel(sessionID)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Session removal no longer waits for prompt cancellation

SessionPrompt.cancel() is now async, but this path drops the returned promise and immediately continues with session teardown. If a processor is still running, it can still emit updates after the session is removed, which reintroduces the delete-time race this PR is otherwise trying to fix.

@kilo-code-bot

kilo-code-bot Bot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 2
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
packages/app/src/pages/session/composer/session-question-dock.tsx 218 Single-select answers no longer submit immediately
packages/opencode/src/session/index.ts 485 Session removal no longer waits for prompt cancellation
Other Observations (not in diff)

No additional issues found outside the diff.

Files Reviewed (18 files)
  • packages/app/src/components/prompt-input.tsx
  • packages/app/src/pages/session.tsx
  • packages/app/src/pages/session/composer/session-composer-region.tsx
  • packages/app/src/pages/session/composer/session-question-dock.tsx - 1 issue
  • packages/app/src/pages/session/file-tabs.tsx
  • packages/app/src/pages/session/use-session-commands.tsx
  • packages/opencode/src/config/config.ts
  • packages/opencode/src/config/tui.ts
  • packages/opencode/src/cli/cmd/tui/plugin/runtime.ts
  • packages/opencode/src/plugin/index.ts
  • packages/opencode/src/plugin/loader.ts
  • packages/opencode/src/plugin/shared.ts
  • packages/opencode/src/session/index.ts - 1 issue
  • packages/opencode/src/session/prompt.ts
  • packages/opencode/test/config/config.test.ts
  • packages/opencode/test/config/tui.test.ts
  • packages/opencode/test/cli/tui/plugin-loader-entrypoint.test.ts
  • packages/opencode/specs/tui-plugins.md

Reviewed by gpt-5.4-20260305 · 2,336,095 tokens

jliounis pushed a commit to jliounis/kilocode that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants