fix(vscode): fall back to generic "Try Model" for long model names#8561
Merged
Conversation
Recover PR #7981 (force-pushed by publish workflow on April 1, 2026). When the suggested model name exceeds 30 characters (after stripping sub-provider prefix), fall back to the generic "Try Model" label to prevent an oversized notification button. Adds tryModelGeneric i18n key for the fallback label across all 18 locales. See #8558
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| {language.t("notifications.action.tryModel", { model: suggestedName() ?? "" })} | ||
| {suggestedName() | ||
| ? language.t("notifications.action.tryModel", { model: suggestedName()! }) | ||
| : language.t("notifications.action.tryModelGeneric")} |
Contributor
Author
There was a problem hiding this comment.
WARNING: Missing uk translation for the new generic label
language.t() returns the key name when a locale entry is missing, so Ukrainian users will see notifications.action.tryModelGeneric on this button. Add the new key to packages/kilo-vscode/webview-ui/src/i18n/uk.ts before shipping.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.4-2026-03-05 · 1,624,960 tokens |
chrarnoldus
approved these changes
Apr 8, 2026
jliounis
pushed a commit
to jliounis/kilocode
that referenced
this pull request
May 18, 2026
fix(vscode): fall back to generic "Try Model" for long model names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover PR #7981 which was lost due to force-push from the publish workflow on April 1, 2026 (see #8558).
tryModelGenerici18n key for the fallback label across all 18 localesWhy 30 characters?
Analyzed the live Kilo Gateway model catalog (~336 models) to find a natural breakpoint in name lengths:
97% of models fit under 30 characters. The 9 models above 30 are verbose edge cases. A 30-char name + "Try " prefix = max 34-char button label, which fits comfortably in the notification card.
Fixes #8558