fix: stabilize worktree branch selector popovers#8386
Merged
Conversation
Render the worktree branch dropdowns inline so the dialog focus trap can keep the filter input keyboard-accessible. Autofocus the search field on open and disable placement flipping so filtering does not make the popup jump.
Keep nested popovers from dismissing their parent dialog when users press Escape. This preserves the branch picker close behavior in the new worktree flow without closing the whole modal.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Files Reviewed (4 files)
Reviewed by gpt-5.4-2026-03-05 · 842,227 tokens |
imanolmzd-svg
approved these changes
Apr 6, 2026
jliounis
pushed a commit
to jliounis/kilocode
that referenced
this pull request
May 18, 2026
fix: stabilize worktree branch selector popovers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-autofocusbehaviorDemo
Before
Arrow keys don't work, typing doesn't work
Screen.Recording.2026-04-05.at.2.39.09.PM.mp4
After
Screen.Recording.2026-04-05.at.2.40.39.PM.mp4