Skip to content

fix: restrict write and apply_patch permissions for plan mode #8360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shssoichiro wants to merge 1 commit into from
Closed

fix: restrict write and apply_patch permissions for plan mode #8360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/opencode/src/agent/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,18 @@ export namespace Agent {
external_directory: {
[path.join(Global.Path.data, "plans", "*")]: "allow",
},
apply_patch: {

@kilo-code-bot kilo-code-bot Bot Apr 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: These new apply_patch/write rules do not enforce the plan-mode restriction.

WriteTool and ApplyPatchTool both call ctx.ask({ permission: "edit", ... }), so the path check still comes from the existing edit rules. PermissionNext.disabled() also maps write to edit, but not apply_patch, which means this block leaves apply_patch exposed to the model while not changing the runtime restriction. The fix likely needs to reuse the edit permission for apply_patch tool gating instead of adding separate apply_patch/write entries here.

@shssoichiro shssoichiro Apr 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Well then this patch isn't needed.

"*": "deny",
[path.join(".kilo", "plans", "*.md")]: "allow", // kilocode_change
[path.join(".opencode", "plans", "*.md")]: "allow", // kilocode_change: .opencode fallback
[path.relative(Instance.worktree, path.join(Global.Path.data, path.join("plans", "*.md")))]: "allow",
},
write: {
"*": "deny",
[path.join(".kilo", "plans", "*.md")]: "allow", // kilocode_change
[path.join(".opencode", "plans", "*.md")]: "allow", // kilocode_change: .opencode fallback
[path.relative(Instance.worktree, path.join(Global.Path.data, path.join("plans", "*.md")))]: "allow",
},
edit: {
"*": "deny",
[path.join(".kilo", "plans", "*.md")]: "allow", // kilocode_change
Expand Down
Loading