Skip to content

fix: add windowsHide:true to remaining spawn/exec calls to prevent CMD flash on Windows#7906

Merged
markijbema merged 2 commits intomainfrom
mark/fix-windows-hide-regression-7896
Mar 31, 2026
Merged

fix: add windowsHide:true to remaining spawn/exec calls to prevent CMD flash on Windows#7906
markijbema merged 2 commits intomainfrom
mark/fix-windows-hide-regression-7896

Conversation

@markijbema
Copy link
Copy Markdown
Contributor

Summary

Changes

File Fix
packages/sdk/js/src/server.ts windowsHide: true on createKiloServer and createKiloTui spawns
packages/sdk/js/src/v2/server.ts Same as above (v2 copy)
packages/opencode/src/kilocode/ts-check.ts windowsHide: true on Bun.spawn for tsc
packages/opencode/src/cli/cmd/github.ts windowsHide: true on exec for browser open
packages/desktop-electron/src/main/cli.ts windowsHide: true on install script spawn and version check
packages/desktop-electron/src/main/ipc.ts windowsHide: true on execFile for open-path
packages/desktop-electron/src/main/apps.ts windowsHide: true on execFileSync for wsl/where calls

windowsHide: true is a no-op on non-Windows platforms, so these changes are safe everywhere.

Closes #7896
Supersedes #7899

kilo-code-bot bot added 2 commits March 30, 2026 07:03
…D flash on Windows

Previous fixes in #6813 and subsequent PRs added windowsHide:true to most
spawn sites, but several call sites were missed or regressed:

- SDK server.ts (v1 + v2): kilo serve and TUI spawn
- ts-check.ts: Bun.spawn for tsc invocation
- github.ts: exec for browser open
- desktop-electron cli.ts: install script spawn and version check
- desktop-electron ipc.ts: open-path execFile
- desktop-electron apps.ts: wsl/where execFileSync calls

Without windowsHide:true, each of these subprocess invocations causes a
visible cmd.exe console window to briefly flash on Windows.

Closes #7896
desktop-electron is not actively maintained and is synced from upstream.
Reverting windowsHide changes in apps.ts, cli.ts, and ipc.ts to keep
the diff from upstream minimal and avoid merge conflicts.
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot bot commented Mar 30, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • packages/opencode/src/cli/cmd/github.ts
  • packages/opencode/src/kilocode/ts-check.ts
  • packages/sdk/js/src/server.ts
  • packages/sdk/js/src/v2/server.ts

Reviewed by gpt-5.4-20260305 · 369,051 tokens

@markijbema markijbema merged commit 9a23857 into main Mar 31, 2026
32 checks passed
@markijbema markijbema deleted the mark/fix-windows-hide-regression-7896 branch March 31, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal/cmd window pops up when agent creates a new file

2 participants