fix: add windowsHide:true to remaining spawn/exec calls to prevent CMD flash on Windows#7906
Merged
markijbema merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
…D flash on Windows Previous fixes in #6813 and subsequent PRs added windowsHide:true to most spawn sites, but several call sites were missed or regressed: - SDK server.ts (v1 + v2): kilo serve and TUI spawn - ts-check.ts: Bun.spawn for tsc invocation - github.ts: exec for browser open - desktop-electron cli.ts: install script spawn and version check - desktop-electron ipc.ts: open-path execFile - desktop-electron apps.ts: wsl/where execFileSync calls Without windowsHide:true, each of these subprocess invocations causes a visible cmd.exe console window to briefly flash on Windows. Closes #7896
desktop-electron is not actively maintained and is synced from upstream. Reverting windowsHide changes in apps.ts, cli.ts, and ipc.ts to keep the diff from upstream minimal and avoid merge conflicts.
marius-kilocode
approved these changes
Mar 30, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by gpt-5.4-20260305 · 369,051 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsHide: trueto all remainingspawn/exec/execFile/execFileSynccalls that were missing it, preventing cmd.exe console windows from briefly flashing on Windows.Changes
packages/sdk/js/src/server.tswindowsHide: trueoncreateKiloServerandcreateKiloTuispawnspackages/sdk/js/src/v2/server.tspackages/opencode/src/kilocode/ts-check.tswindowsHide: trueonBun.spawnfor tscpackages/opencode/src/cli/cmd/github.tswindowsHide: trueonexecfor browser openpackages/desktop-electron/src/main/cli.tswindowsHide: trueon install script spawn and version checkpackages/desktop-electron/src/main/ipc.tswindowsHide: trueonexecFilefor open-pathpackages/desktop-electron/src/main/apps.tswindowsHide: trueonexecFileSyncfor wsl/where callswindowsHide: trueis a no-op on non-Windows platforms, so these changes are safe everywhere.Closes #7896
Supersedes #7899