docs(cli): clarify hidden .kilo install artifact behavior#6540
Conversation
|
@sonwr is attempting to deploy a commit to the Kilo Code Team on Vercel. A member of the Team first needs to authorize it. |
| }) | ||
|
|
||
| test("links npm bin commands to the wrapper during local install", async () => { | ||
| const tmp = await fs.mkdtemp(path.join(os.tmpdir(), "kilo-install-artifact-")) |
There was a problem hiding this comment.
WARNING: Missing temp directory cleanup
fs.mkdtemp creates a temporary directory that is never cleaned up after the test completes. Over repeated test runs (especially in CI), this will accumulate orphaned directories in the system temp folder.
Consider adding cleanup in a finally block or using afterAll/afterEach:
let tmp: string
afterEach(async () => {
if (tmp) await fs.rm(tmp, { recursive: true, force: true })
})
Code Review SummaryStatus: No New Issues Found | Recommendation: Merge OverviewThis PR adds a README note explaining the hidden Both changes are clean and well-structured:
No security vulnerabilities, runtime errors, logic bugs, or breaking changes detected. Files Reviewed (2 files)
|
|
Thanks for the careful review — great catch.\n\nI added temp directory cleanup in the test using a block with to avoid orphaned directories across repeated runs/CI.\n\nAlso re-ran the focused test:\n- \n- Result: 2 passed |
|
Apologies — reposting cleanly. Thanks for the careful review — great catch. I added temp directory cleanup in the test using a try/finally block with: Re-ran focused test:
|
|
Quick note: the I re-ran the focused test locally after the cleanup fix:
|
|
Thanks for the follow-up review — addressed. I added an explicit npm availability guard in the test:
This keeps CI behavior explicit in environments that only provide Bun. Re-ran focused test:
|
…-artifact docs(cli): clarify hidden .kilo install artifact behavior
Summary
This PR clarifies the hidden
.kilofile that some users see after npm-based CLI installs, and adds a small regression test around install artifact behavior.What changed
.kilois,packages/opencode/test/cli/install-artifact.test.tsto verify:kiloandkilocode,.kiloartifact shape when present.Validation
cd packages/opencode && bun test test/cli/install-artifact.test.ts✅ (2 passed)Fixes #6521